[Fix] 지도 산 조회 부분에서 imageUrl이 항상 null인 문제 수정#183
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 지도 영역 내 산 조회 API에서 imageUrl이 항상 null로 반환되던 문제를 해결합니다. 기존에는 사용자 등산 기록에서 이미지를 가져오려 했으나, 이를 산 자체의 기본 이미지를 참조하도록 수정하여 데이터 일관성을 확보했습니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
이번 풀이 리퀘스트에서는 MountainRepository.java 파일 내 findRecommendationsByDifficulties 메서드의 쿼리를 수정하였습니다. 기존에 사용자별 하이킹 기록(hiking_records, hiking_members)을 서브쿼리로 조회하여 최신 이미지 URL을 가져오던 복잡한 로직을, mountains 테이블의 image_urls JSON 컬럼에서 첫 번째 요소를 직접 추출(m.image_urls->>0)하는 방식으로 단순화하여 성능을 개선했습니다. 제출된 리뷰 코멘트가 없으므로 추가로 제공할 피드백은 없습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🧾 요약
/api/mountains/map)에서 imageUrl이 항상 null로 내려오는 문제 수정 — 산 기본 이미지를 반환하도록 쿼리 변경🔗 이슈
✨ 변경 내용
MountainRepository.findInBBoxWithUserHikingStats쿼리에서 등산 기록 사진 서브쿼리를m.image_urls->>0(산 기본 이미지)으로 교체✅ 확인