Skip to content

[Fix] 지도 산 조회 부분에서 imageUrl이 항상 null인 문제 수정#183

Merged
howooyeon merged 1 commit into
developfrom
fix/#182-mountain-map-image
Jun 3, 2026
Merged

[Fix] 지도 산 조회 부분에서 imageUrl이 항상 null인 문제 수정#183
howooyeon merged 1 commit into
developfrom
fix/#182-mountain-map-image

Conversation

@howooyeon

@howooyeon howooyeon commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🧾 요약

  • 지도 영역 내 산 조회 API(/api/mountains/map)에서 imageUrl이 항상 null로 내려오는 문제 수정 — 산 기본 이미지를 반환하도록 쿼리 변경

🔗 이슈

✨ 변경 내용

  • MountainRepository.findInBBoxWithUserHikingStats 쿼리에서 등산 기록 사진 서브쿼리를 m.image_urls->>0(산 기본 이미지)으로 교체

✅ 확인

  • 빌드 OK
  • 테스트 OK

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c0aee93-cbcb-413b-836e-e1f05ac61f15

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#182-mountain-map-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@howooyeon howooyeon self-assigned this Jun 3, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 지도 영역 내 산 조회 API에서 imageUrl이 항상 null로 반환되던 문제를 해결합니다. 기존에는 사용자 등산 기록에서 이미지를 가져오려 했으나, 이를 산 자체의 기본 이미지를 참조하도록 수정하여 데이터 일관성을 확보했습니다.

Highlights

  • 이미지 조회 로직 수정: 지도 산 조회 API에서 기존의 복잡한 등산 기록 이미지 서브쿼리를 제거하고, 산 기본 이미지(image_urls의 첫 번째 요소)를 반환하도록 쿼리를 변경했습니다.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@howooyeon
howooyeon merged commit 53ea03a into develop Jun 3, 2026
3 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 풀이 리퀘스트에서는 MountainRepository.java 파일 내 findRecommendationsByDifficulties 메서드의 쿼리를 수정하였습니다. 기존에 사용자별 하이킹 기록(hiking_records, hiking_members)을 서브쿼리로 조회하여 최신 이미지 URL을 가져오던 복잡한 로직을, mountains 테이블의 image_urls JSON 컬럼에서 첫 번째 요소를 직접 추출(m.image_urls->>0)하는 방식으로 단순화하여 성능을 개선했습니다. 제출된 리뷰 코멘트가 없으므로 추가로 제공할 피드백은 없습니다.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@howooyeon
howooyeon deleted the fix/#182-mountain-map-image branch June 5, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 지도 영역 내 산 조회 API에서 imageUrl이 항상 null인 문제

1 participant